phsjhxx

30. Always close locally opened cursors. (CodeXpert)
[CodeXpert 2601]
Reason: Any cursors left open can consume additional System Global Area (i.e.
SGA) memory space within the database instance, potentially in both the
shared and private SQL pools. Furthermore, failure to explicitly close
cursors may also cause the owning session to exceed its maximum limit of
open cursors (as specified by the OPEN_CURSORS database initialization
parameter), potentially resulting in the Oracle error of “ORA-01000:
maximum open cursors exceeded”. For example, the following procedure
opens and fetches, but does not close its cursor – which may cause
problems like those described above.
Example:
-- bad
CREATE PROCEDURE not_close_cursor (out_count OUT INTEGER)
AS
CURSOR c1
IS
BEGIN
SELECT COUNT (*)
FROM all_users;
out_count := 0;
OPEN c1;
FETCH c1
INTO out_count;
END not_close_cursor;
...
-- Good
CREATE PROCEDURE close_cursor (out_count OUT INTEGER)
AS
CURSOR c1
IS
SELECT COUNT (*)
FROM all_users;
BEGIN
out_count := 0;
OPEN c1;
FETCH c1
INTO out_count;
CLOSE c1
END close_cursor;
PL/SQL Coding Guidelines 27