08.01.2015 Views

phsjhxx

phsjhxx

phsjhxx

SHOW MORE
SHOW LESS

Create successful ePaper yourself

Turn your PDF publications into a flip-book with our unique Google optimized e-Paper software.

43. Try to label your EXIT WHEN statements.<br />

Example:<br />

-- Good<br />

BEGIN<br />

END;<br />

l_outerlp := 0;<br />

<br />

LOOP<br />

l_innerlp := 0;<br />

l_outerlp := NVL(l_outerlp,0) + 1;<br />

<br />

LOOP<br />

l_innerlp := NVL(l_innerlp,0) + 1;<br />

DBMS_OUTPUT.PUT_LINE('Outer Loop counter is ' || l_outerlp ||<br />

EXIT outerloop WHEN l_innerlp = 3;<br />

END LOOP innerloop;<br />

END LOOP outerloop;<br />

' Inner Loop counter is ' || l_innerlp);<br />

44. Do not use a cursor for loop to check whether a cursor returns data.<br />

Example:<br />

-- Bad<br />

DECLARE<br />

l_employee_found BOOLEAN := FALSE;<br />

…<br />

BEGIN<br />

END;<br />

<br />

FOR r_employee IN c_employee<br />

LOOP<br />

l_employee_found := TRUE;<br />

END LOOP check_employees;<br />

-- Good<br />

DECLARE<br />

l_employee_found BOOLEAN := FALSE;<br />

…<br />

BEGIN<br />

OPEN c_employee;<br />

FETCH c_employee INTO r_employee;<br />

l_employee_found := c_employee%FOUND;<br />

CLOSE c_emplyoee;<br />

END;<br />

PL/SQL Coding Guidelines 33

Hooray! Your file is uploaded and ready to be published.

Saved successfully!

Ooh no, something went wrong!